Opened 9 months ago

Closed 7 months ago

#21863 closed defect (bug) (fixed)

box-sizing breaks some admin-bar elements

Reported by: betzster Owned by: nacin
Priority: normal Milestone: 3.5
Component: Toolbar Version: 3.5
Severity: minor Keywords: has-patch commit
Cc:

Description

If I do something like * { box-sizing: border-box; } in my theme, it breaks some of the admin-bar elements — the stats item in particular is affected. This is easily fixed by forcing everything in #wpadminbar to box-sizing: content-box.

Attachments (2)

21863.patch​ (446 bytes) - added by betzster 9 months ago.
Adds box-sizing: content-box to everything in #wpadminbar
21863.2.patch​ (451 bytes) - added by SergeyBiryukov 9 months ago.
With proper formatting

Download all attachments as: .zip

Change History (7)

betzster — 9 months ago

Adds box-sizing: content-box to everything in #wpadminbar

comment:1   nacin — 9 months ago

  • Milestone changed from Awaiting Review to 3.5

SergeyBiryukov — 9 months ago

With proper formatting

comment:2   SergeyBiryukov — 9 months ago

See ​CSS Coding Standards for the preferred formatting.

comment:3   SergeyBiryukov — 9 months ago

  • Component changed from Administration to Toolbar

comment:4   helenyhou — 7 months ago

  • Keywords commit added

[21863.2.patch] seems to work for me, didn't notice anything broken without it in core items but definitely see the inconsistencies and potential for breakage.

comment:5   nacin — 7 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [22280]:

Reset box-sizing to toolbar CSS to avoid conflicts with themes. props betzster, fixes #21863.

Note: See TracTickets for help on using tickets.