Opened 8 months ago
Closed 8 months ago
#21886 closed enhancement (fixed)
PHPDocs for options_reading_blog_charset()
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.5 |
| Component: | Inline Docs | Version: | 3.5 |
| Severity: | trivial | Keywords: | has-patch |
| Cc: |
Description
Background: #21507
Attachments (4)
Change History (9)
SergeyBiryukov — 8 months ago
SergeyBiryukov — 8 months ago
- Owner set to nacin
- Resolution set to fixed
- Status changed from new to closed
In [21872]:
SergeyBiryukov — 8 months ago
comment:2
SergeyBiryukov — 8 months ago
- Resolution fixed deleted
- Status changed from closed to reopened
add_js() was originally added in 3.1: [15946] (for #15205). Was the change to 3.5 in the commit intentional?
21886.3.patch adds @since for other *_add_js() functions.
Not sure if @package and @subpackage are relevant for those functions. The patch removes them for consistency with [21872].
@package and @subpackage are rarely relevant for functions at all. Since we renamed add_js(), I changed the @since to when it was actually introduced. Normally we'd also include some info about when it was originally introduced (before rename), but this is just a formality, as these are internal functions anyway.
SergeyBiryukov — 8 months ago
comment:4
SergeyBiryukov — 8 months ago
I see. 21886.4.patch adds @since 3.5.0 for other renamed functions.
Refreshed after [21856]