Opened 8 months ago
Closed 8 months ago
#21932 closed defect (bug) (fixed)
Twenty Twelve: Missing style rules for html elements that can be added in the text widget.
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | low | Milestone: | 3.5 |
| Component: | Bundled Theme | Version: | |
| Severity: | normal | Keywords: | has-patch |
| Cc: | xoodrew@… |
Description
Since Twenty Twelve limits the styles for many html elements specifically inside .entry-content and .comment-content, (See Line 662 - 864 in style.css) those that can be inside a text widget are left unstyled.
As users are able to add html elements in a text widget, those should be styled accordingly as well.
Attachments (3)
Change History (9)
comment:1
lancewillett — 8 months ago
- Keywords needs-patch added
- Milestone changed from Awaiting Review to 3.5
- Priority changed from normal to low
comment:2
lancewillett — 8 months ago
#21965 was marked as a duplicate.
comment:3
lancewillett — 8 months ago
I vote on only styling simple things, like paragraph elements and unordered lists. (Not headings and all other possible HTML input.)
comment:4
DrewAPicture — 8 months ago
- Cc xoodrew@… added
- Keywords has-patch added; needs-patch removed
With 21932.diff:
FF 15: http://cl.ly/image/1Q1a45163U41
Chrome 21: http://cl.ly/image/2T380h3B0q2G
Safari 6: http://cl.ly/image/0L0P0q0p1G2q
Opera 12: http://cl.ly/image/0i2c1o3w1D10
comment:5
lancewillett — 8 months ago
Thanks for the patch and screenshots. After testing, I think we should apply the p styles to .widget and the list and list item styles only to .textwidget.
lancewillett — 8 months ago
comment:6
lancewillett — 8 months ago
- Owner set to lancewillett
- Resolution set to fixed
- Status changed from new to closed
In [21990]:
Thanks for the ticket, Takashi. I'm going to mark as minor since it's not a blocker for 1.0 going to Extend, in my opinion. But, it should be addressed soon.