.widefat select has a gray background, unlike inputs which are white

[alexvorn2]

​http://wpimpact.com/wp-content/uploads/2012/09/Untitled-2w.png

remove widefat class form select input tags in Widgets...
widefat class makes select element darker, like in Pages widget

Would it make sense to just make the background for .widefat select elements white? It is for text-type inputs. I never really understood why it was a different color.

Replying to helenyhou:

Would it make sense to just make the background for .widefat select elements white? It is for text-type inputs. I never really understood why it was a different color.

It seems that 'widefat' makes the select input wide, so removing the class is a bad idea, changing the color is a better one... thanks for suggestion!

style update.

update to the non min version

MikeHansenMe - Perhaps you meant to change the background rather than the border color?

Yea, my bad. I will get an update up shortly.

background color change

background-color on min file

That should be the correct change.

You don't need to patch the minified files - a post-commit bot takes care of it. Also, I think it may already have been the right color in this case, but changes in colors-fresh.css often need a parallel change in colors-classic.css (blue).

I wondered about the min version but figured I would include it anyway. I think the color(f9f9f9) on color fresh is different from the other fields(fff). Color classic seems to match already.

so is this good for 3.6 milestone? I thought that at 3.5 update this will be fixed :(

Have to figure out why it was that color in the first place before we can just change it.

.widefat is used on the import page to style the table.

Maybe there should be another rule "select.widefat" just as there is a "textarea.widefat" or possible even a new class to use on input/select/textarea to reduce css. I think the original reason for this being used was just to get width: 100%;

Patch works, no unwanted side effects.

Update: did not work, I must have had another patch active. Reverted, tested again. being overwritten by CSS (my bad, need coffee).

.widefat has the background color defined in the color CSS files, with textarea.widefat getting the background color treatment to override. I would suggest either putting the select.widefat rule there, or to change the .widefat declaration for border and background colors to table.widefat.

+1 for table.widefat

My suggestion requiring testing for consequences, of course :)

update based on Helen's comment.

21936.5.diff​ removes what would be an unnecessary rule for textarea.widefat. I tested around the admin and don't see any detrimental effects. The tag cloud widget has a select.widefat, for an existing example.

Nice, the text widget did use textarea.widefat but is now taking the width 100% from .widefat and background of #fff from the default textarea css rule. So it looks correct.

In 23315:

Make sure .widefat border and background coloring only applies to tables. props MikeHansenMe. fixes #21936.