WordPress.org

Make WordPress Core

Opened 9 months ago

Closed 7 months ago

#21956 closed defect (bug) (fixed)

Long name in Page Template metabox breaks admin layout

Reported by: Ov3rfly Owned by: nacin
Priority: normal Milestone: 3.5
Component: UI Version: 3.4
Severity: normal Keywords: has-patch ui-feedback
Cc: SergeyBiryukov, mdhansen@…

Description

Long template names shown in Page Template metabox in admin interface break the layout to the right, see attachment.

Possible fix: "max-width" css for select id="page_template"

Attachments (4)

page-template-box-too-wide.png​ (5.0 KB) - added by Ov3rfly 9 months ago.
21956.patch​ (343 bytes) - added by ocean90 9 months ago.
21956.2.patch​ (1.1 KB) - added by SergeyBiryukov 9 months ago.
21956.3.patch​ (1.1 KB) - added by SergeyBiryukov 9 months ago.

Download all attachments as: .zip

Change History (13)

Ov3rfly — 9 months ago

comment:1 ocean90 — 9 months ago

Related: #18453

Version 0, edited 9 months ago by ocean90 (next)

ocean90 — 9 months ago

comment:2 ocean90 — 9 months ago

  • Cc SergeyBiryukov added
  • Component changed from Administration to UI
  • Keywords has-patch added
  • Version changed from 3.4.2 to 3.4

SergeyBiryukov — 9 months ago

comment:3 SergeyBiryukov — 9 months ago

  • Milestone changed from Awaiting Review to 3.5

Looks good. 21956.2.patch​ does the same in Quick Edit.

IE 7/8 requires fixed width (related: ticket:21752:3, also addressed in the patch).

Last edited 9 months ago by SergeyBiryukov (previous) (diff)

comment:4 SergeyBiryukov — 9 months ago

Tested in Firefox 15, Chrome 21, IE 7, IE 8, Opera 12.

comment:5 nacin — 9 months ago

For quick edit, we also have to account for the label when doing max-width: 100%. Something like max-width: 80% will account for the label except at much narrower widths.

SergeyBiryukov — 9 months ago

comment:6 SergeyBiryukov — 9 months ago

21956.3.patch​ adds max-width: 80% for Quick Edit.

comment:7 MikeHansenMe — 8 months ago

  • Cc mdhansen@… added

Tested 21956.3.patch on Ubuntu with Chrome 20 and Firefox 16, did not test IE. Looks good for me.

comment:8 SergeyBiryukov — 8 months ago

  • Keywords ui-feedback added

comment:9 nacin — 7 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 22443:

Try to avoid overflow of the page template dropdown with long template names. props SergeyBiryukov, ocean90. fixes #21956.

Note: See TracTickets for help on using tickets.