Opened 8 months ago
Closed 8 months ago
#22019 closed enhancement (fixed)
Twenty Twelve: wrong math in style.css rem example
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.5 |
| Component: | Bundled Theme | Version: | 3.5 |
| Severity: | normal | Keywords: | |
| Cc: | xoodrew@… |
Description (last modified by SergeyBiryukov)
22 $rembase: 14; 23 $line-height: 24; 24 25 ---------- Examples 31 * Set a font-size and then set a line-height based on the font-size 32 font-size: 16px 33 font-size: 1.142857143rem; (16 / $rembase) 34 line-height: 1.846153846; ($line-height / 16)
line-height = $line-height: 24 / 16 = 1.5
Or I'm wrong? How can we get 1.846153846?
Change History (6)
comment:1
in reply to:
↑ description
TomasM — 8 months ago
- Summary changed from Twenty Ten - wrong math in style.css rem example to Twenty Twelve - wrong math in style.css rem example
comment:2
SergeyBiryukov — 8 months ago
- Description modified (diff)
- Summary changed from Twenty Twelve - wrong math in style.css rem example to Twenty Twelve: wrong math in style.css rem example
comment:3
lancewillett — 8 months ago
- Milestone changed from Awaiting Review to 3.5
comment:4
DrewAPicture — 8 months ago
- Cc xoodrew@… added
After talking to @lancewillett a little more about this I'm gonna go with the example being wrong. We'll need to find out if the 24 baseline was intended to be absolute.
comment:5
lancewillett — 8 months ago
- Keywords dev-feedback removed
Talked it over with @drewstrojny (the other Drew!) and he confirmed it's a math mistake, the values throughout the stylesheet are correct.
comment:6
lancewillett — 8 months ago
- Owner set to lancewillett
- Resolution set to fixed
- Status changed from new to closed
In [22069]:
Note: See
TracTickets for help on using
tickets.

Sorry I had in mind Twenty Twelve.