After "clear background-color" in design options, still css is added to html-output

[Ov3rfly]

After you select "clear background-color" in design options, the default color still is added as inline css to html-output of frontend.

Tested with 3.4.2 and Twenty Twelve 1.0 theme

Steps to reproduce:

1. Look at default html-output, no inline css for background-color
2. Design -> Background -> Color, select e.g. color #123456, save
3. Look at html-output, this is added:

<style type="text/css" id="custom-background-css">
body.custom-background { background-color: #123456; }
</style>

4. Design -> Background -> Color -> Click "clear" option, save
5. Look at html-output, this is added with default value:

<style type="text/css" id="custom-background-css">
body.custom-background { background-color: #e6e6e6; }
</style>

Expected behaviour: After "clear" option is used and default value #e6e6e6 (or only a #) is shown in backend, no inline css should be included in html output of frontend.

I believe this is intentional as #e6e6e6 is the default background color for Twenty Twelve. See #21226.

Suggest close.

Yes, this is intentional with Twenty Twelve. WP now allows you to set a default background color in the theme functions file. When you "clear the color" in Appearance > Background it should revert back to the default color value.

Opened #22038 to discuss UX of default background colors.

In a new wordpress install, where no value has been set for custom background-color via backend yet, no inline css is added to front end html, as expected.

After a value for custom background-color has been saved, the inline css appears, as expected.

But (and that's the bug here) it does not disappear again (as it should), if the value is "cleared" via the backend "clear" option.

The currently only way to remove that inline css again, is to delete the entry theme_mods_twentytwelve in database wp_options table.

Expected behaviour: No/empty/cleared setting = no extra inline css.

Note: The default background color comes from style.css, no inline code required. And about the theme functions.php file, if there is no add_theme_support() for custom-background, again no inline code required.

Related: #22038 – Bad UX with default background color

Tested 22030.1.2 with 3.4.2, works exactly as expected. Thanks.

22030.1.2 patch looks good, let's get this in.

Related code here has a lot of history. See [21054] and all of the tickets it links to. This does not regress any of those issues, correct?