Opened 8 months ago

Closed 8 months ago

#22052 closed defect (bug) (duplicate)

Add `no-customize-support` to default body classes

Reported by: DrewAPicture Owned by:
Priority: normal Milestone:
Component: Toolbar Version: 3.4
Severity: normal Keywords: has-patch
Cc: xoodrew@…

Description

In order for hide-if-no-customize in the Toolbar to work, no-customize-support has to be added by default to the body classes. If there is Customize support, wp_customize_support_script() rewrites it to customize-support.

Related: #20751

Patch attached.

Attachments (2)

22052.diff​ (438 bytes) - added by DrewAPicture 8 months ago.
22052.2.diff​ (535 bytes) - added by DrewAPicture 8 months ago.
braces

Download all attachments as: .zip

Change History (6)

DrewAPicture — 8 months ago

comment:1 follow-up: ↓ 2   SergeyBiryukov — 8 months ago

The formatting in 22052.diff​ is confusing. Should no-customize-support only be added if is_admin_bar_showing()? In that case, the braces are missing.

DrewAPicture — 8 months ago

braces

comment:2 in reply to: ↑ 1   DrewAPicture — 8 months ago

  • Cc xoodrew@… added

Replying to SergeyBiryukov:

Should no-customize-support only be added if is_admin_bar_showing()? In that case, the braces are missing.

The only instance of hide-if-no-customize on the front-end is on the Customize link in the Toolbar, so if it isn't showing, the class is moot. 22052.2.diff​ adds the braces.

comment:3   SergeyBiryukov — 8 months ago

  • Milestone changed from Awaiting Review to 3.5

comment:4   obenland — 8 months ago

  • Milestone 3.5 deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Duplicate of #20896.

Note: See TracTickets for help on using tickets.