Toolbar: username vs user_nicename in My Account dropdown

[DrewAPicture]

Per ​a discussion in the forums, there is some confusion about the presentation of user_nicename in the My Account Toolbar menu, specifically in the context of email address-like usernames. As it is now, the Display Name is in bold with the nicename below. See here: ​http://cl.ly/image/2y423k441F0j

Either:

A) The span class of username is incorrect because we're displaying the user_nicename (and you can't login with the nicename)

B) The span class is correct and we should be displaying the username.

Introduced in [18776]. I guess it should be username there.

In 23360:

Display username (user_login) rather than user_nicename in Toolbar. fixes #22121.

I do not agree with this decision. Most of people take screenshots to show something on a plugin setting page, on dashboard, to explain some problem, to illustrate a tutorial.
So, now we will see their login ? Wow, strange and not secure.
Can we discuss about this ?

Replying to juliobox:

So, now we will see their login ?

Only if they open the "My Account" menu when taking a screenshot: ​http://cl.ly/image/2y423k441F0j.

Wow, strange and not secure.

user_nicename is a URL-friendly version of the username. Most of the time they are the same anyway, so I don't think displaying user_nicename was more secure. It just make less sense outside of URL context. Moreover, we don't consider this information disclosure, see #3708.

"are the same" by default, by security you have to change it to avoid to display your login in some CSS classes.
SO, i was wrong about the screenshot, if we have to slide down the menu, ok for me, thank you Sergey (and congrats for what you know ;p)