wp_basename wrong on Windows Systems

[sebber]

On Windows System the Directory Seperator is \ instead of Unix /.

So the urlencode in wp_basename() encodes the \ and it is not removed in basename().

WP_basename is not working properly on Windows Systems.

Just take a look in the Support Forum:

​http://wordpress.org/support/topic/function-wp_basename-is-wrong-in-windows?replies=3

Possible Resolution:

function wp_basename( $path, $suffix = '' ) {
$path = str_replace( '\', '/', $path );
$path = str_replace( '%2F', '/', urlencode( $path ) );
return urldecode( basename( $path ), $suffix );

}

Confirmed. wp_basename() is mostly used on attachment URLs in core, which is why, I guess, we didn't catch this earlier.

I checked your solution. It seems all right. Thank you

I added ​unit tests for wp_basename for this situation.

Obviously, I also tested, and 22138.patch​ works.

In [22310]:

Fix wp_basename() for Windows by replacing %5C with /.

Props SergeyBiryukov
fixes #22138