Opened 7 months ago
Last modified 6 months ago
#22164 new enhancement
Move comment "keyboard shortcuts" setting to comments -> screen options
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Future Release |
| Component: | Comments | Version: | |
| Severity: | normal | Keywords: | has-patch |
| Cc: | knut@… |
Attachments (2)
Change History (9)
- Keywords needs-patch added
- Milestone changed from Awaiting Review to Future Release
comment:2
SergeyBiryukov — 7 months ago
Related: #21414
SergeyBiryukov — 7 months ago
comment:3
SergeyBiryukov — 7 months ago
- Keywords has-patch added; needs-patch removed
Played around with this today a bit. A few things:
1) Keyboard shortcuts should live-toggle based on the state of the checkbox.
2) I can't get $.hotkeys.remove() to work, as I think it tries to reach into long-gone jQuery internals. When looking into that, our jQuery Hotkeys plugin is terribly out of date. It is beta 2, by beta 7, it was completely rewritten, and then 3 years ago, Resig rewrote it: https://github.com/jeresig/jquery.hotkeys. If we can't hack in a fix to hotkeys, in order to update hotkeys, we'll need to rewrite our table_hotkeys.
I started on the front-end, while Sergey handled the backend. If we can work out how to remove events, we should be able to combine both patches.
comment:5
in reply to:
↑ 4
SergeyBiryukov — 7 months ago
Replying to nacin:
our jQuery Hotkeys plugin is terribly out of date.
Related: #19489. Initial attempt at refactoring table-hotkeys.js: ticket:20885:20885.patch.
This seems like a great thing for 3.6 early, I think. Definitely not as simple as it appears, and I think anything less than having it turn on and off immediately (and without a page refresh) is not worth it.


This was recently done on WordPress.com, and a few members of the core team reacted positively (including me, Mark, and Matt).
This goes in line with removing and simplifying options/settings screens in 3.5, so if it has a (simple) patch (soon), it could be considered.