Twenty Twelve: style MultiSite messages and forms

[pavelevap]

I tested Twenty Twelve with Multisite and it does not look very good (see attached screenshot). Maybe bundled themes could also support basic Multisite forms and activation messages?

Confirmed the problem on Multisite. Definitely doesn't look good at all. Nice catch @pavelevap!

Looks to me like the biggest problem here is that all standard styles are currently targeted, meaning we don't have standalone p, ul, li, h2 in the stylesheet. I propose we add the untargeted styles but I'm working two patches, so @lancewillet or whomever can choose.

Standalone ul, li, p, h2

22179-standalone.diff​ adds standalone ul, li, p and h2 styles. I've also attached three resulting screenshots:

• 22179-standalone.png​
• 22179-standalone-2.png​
• 22179-standalone-3.png​

I'm scrapping my effort on the override/targeted patch, mostly because we'd essentially be printing the original styles followed by the overriding styles in the page (which is lame).

On a side note, wp-signup.php looks like a primo candidate for some love at WCDenver Hack Day this weekend.

I'm reasonably confident the standalone styles will suffice here, but I'd love to hear others' feedback.

Replying to DrewAPicture:

Looks to me like the biggest problem here is that all standard styles are currently targeted, meaning we don't have standalone p, ul, li, h2 in the stylesheet. I propose we add the untargeted styles but I'm working two patches, so @lancewillet or whomever can choose.

I don't think we should add any standalone styles. Much better to target with a specific class, please.

Shouldn't system messages like this be styled by WP core itself?

Replying to lancewillett:

Shouldn't system messages like this be styled by WP core itself?

The form elements are styled in-file, but it's assumed that themes will supply basic untargeted ui, li, p and h2 styles, as every theme I've tested besides Twenty Twelve seem to have.

targeted

22179-2.diff​ adds the styles targeted to the .mu_register class.

I still don't really understand the hesitation behind providing basic un-targeted element type selector styles for p, h-tags, lists, etc. They could be easily bundled in with existing rules.

Replying to DrewAPicture:

22179-2.diff​ adds the styles targeted to the .mu_register class.

I still don't really understand the hesitation behind providing basic un-targeted element type selector styles for p, h-tags, lists, etc. They could be easily bundled in with existing rules.

Because we've already launched the theme publicly, and we need to be *very* careful about changing styles that could break things. We can do it, just will take oodles of testing so won't be a quick one to commit.

I think our best approach here is to add selectors for .mu_register in with the existing .entry-content selectors; then anything that's specific to multisite can go below in its own rule block.

In 22579:

Twenty Twelve: style Multisite messages and forms to match the theme styles. Props DrewAPicture and obenland, fixes #22179.