Opened 7 months ago

Closed 7 months ago

#22224 closed defect (bug) (fixed)

E_STRICT errors in WP_Plugins_List_Table/WP_List_Table

Reported by: alan-c Owned by: ryan
Priority: normal Milestone: 3.5
Component: Warnings/Notices Version: 3.1
Severity: normal Keywords: has-patch
Cc: kurtpayne

Description

2 E_STRICT errors caused by WP_Plugins_List_Table/WP_List_Table:

Declaration of WP_Plugins_List_Table::bulk_actions() should be compatible with that of WP_List_Table::bulk_actions()

Declaration of WP_Plugins_List_Table::single_row() should be compatible with that of WP_List_Table::single_row()

The WP_Plugins_List_Table methods have an extra argument versus the same method in the parent class (WP_List_Table).

Attachments (1)

22224.patch​ (1.5 KB) - added by kurtpayne 7 months ago.

Download all attachments as: .zip

Change History (7)

comment:1   SergeyBiryukov — 7 months ago

  • Component changed from Plugins to Warnings/Notices

comment:2   kurtpayne — 7 months ago

  • Cc kurtpayne added
  • Version changed from 3.4.2 to 3.1

Bug confirmed.

There is also a mismatch between WP_Plugins_List_Table::single_row and WP_List_Table::single_row.

kurtpayne — 7 months ago

comment:3   kurtpayne — 7 months ago

  • Keywords has-patch added; needs-patch removed

comment:4   SergeyBiryukov — 7 months ago

  • Milestone changed from Awaiting Review to 3.5
  • Version changed from 3.1 to 3.4.2

comment:5   SergeyBiryukov — 7 months ago

  • Version changed from 3.4.2 to 3.1

comment:6   ryan — 7 months ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In 22376:

Fix strict warnings for WP_Plugins_List_Table::bulk_actions() and WP_Plugins_List_Table::single_row(). Props kurtpayne. fixes #22224

Note: See TracTickets for help on using tickets.