Opened 8 months ago
Last modified 4 months ago
#22254 new defect (bug)
"Do you really want to log out" message after already logged out
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Awaiting Review |
| Component: | Administration | Version: | 3.4.2 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | mdhansen@… |
Description
- Log into admin area
- Open some page within admin area in a new tab (middle click or "Open link in new tab" or similar)
- Select "Log Out" in menu in one tab
- Normal "You are now logged out." screen appears
- Select "Log Out" in menu in other tab
- The following message appears:
You are attempting to log out of Blogname Do you really want to log out?
The content of this message is wrong as the user is already logged out at this point.
Attachments (1)
Change History (12)
MikeHansenMe
— 8 months ago
comment:1
MikeHansenMe
— 8 months ago
- Cc mdhansen@… added
comment:2
SergeyBiryukov
— 8 months ago
- Keywords has-patch added
comment:3
MikeHansenMe
— 5 months ago
- Keywords needs-testing added
comment:4
SergeyBiryukov
— 5 months ago
- Milestone changed from Awaiting Review to 3.6
comment:5
aaronholbrook
— 5 months ago
Tested, worked great.
comment:7
MikeHansenMe
— 5 months ago
Thanks for testing the patch guys
comment:8
SergeyBiryukov
— 4 months ago
- Keywords commit added
comment:10
nacin
— 4 months ago
A few things:
- I don't think this is the right place for this code. Rather than going in wp_nonce_ays() — where messages for failed nonces get printed — the nonce check should be avoided all together, in wp-login.php's action = logout branch.
- I'm not sure this is necessary at all. The user may be "logged out" by having the logged_in cookie drop, but they may still have admin cookies and it would be good for those to be removed. By providing an extra step, we can ensure that they have an opportunity to explicitly log out and remove all cookies.
- For more, see #14949, which covers the logging-in-when-already-logged-in problem. This is just the reverse — logging out when already logged out.
comment:11
nacin
— 4 months ago
- Keywords commit removed
- Milestone changed from 3.6 to Awaiting Review
Note: See
TracTickets for help on using
tickets.
send logged out user straight to login form