Opened 8 months ago
Closed 7 months ago
#22284 closed defect (bug) (fixed)
Beta Media button fails on frontend
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | low | Milestone: | 3.5 |
| Component: | Media | Version: | 3.5 |
| Severity: | normal | Keywords: | |
| Cc: |
Description
Basically, if you add wp_editor() somewhere on the frontend and then hit the new beta media button you get a JS error (TypeError: e is undefined) in underscore.min.js.
Tested this with the latest trunk on TwentyTwelve with no active plugins.
Attachments (3)
Change History (18)
comment:1
SergeyBiryukov
— 8 months ago
- Component changed from External Libraries to Media
comment:2
SergeyBiryukov
— 8 months ago
- Milestone changed from Awaiting Review to 3.5
comment:3
bpetty
— 8 months ago
comment:5
koopersmith
— 7 months ago
In 22699:
comment:6
koopersmith
— 7 months ago
Using media on the frontend with wp_editor() currently does not cause any errors. That said, we could use a few bits of CSS to lock the styles in place.
Enqueuing anything that depends on wp-plupload (such as media-upload) without calling wp_plupload_default_settings() first will cause any dependent script to break, as wp.Uploader bails without its settings. The best way to fix this at the moment is probably to inspect whether the wp-plupload script is enqueued at the standard script printing points, and if so, generate its settings first.
comment:7
koopersmith
— 7 months ago
- Priority changed from normal to low
comment:8
koopersmith
— 7 months ago
In 22776:
comment:10
koopersmith
— 7 months ago
In 22779:
comment:11
koopersmith
— 7 months ago
In 22780:
comment:12
lessbloat
— 7 months ago
A few more minor CSS tweaks in 22284.2.diff.
comment:13
lessbloat
— 7 months ago
22284.3.diff adds default link colors & removes need for !important.
comment:14
koopersmith
— 7 months ago
In 22782:
comment:15
koopersmith
— 7 months ago
- Resolution set to fixed
- Status changed from new to closed
Closing this as fixed. If there are any additional display issues on the front-end, please open a new ticket.
There's certainly something wrong here as I also get JS errors, though it's slightly different errors: