enhance urlencode_deep()

[wpmuguru]

It would be handy if urlencode_deep() handled objects as well as arrays. Patch includes corresponding urldecode_deep()

You don't really need the squigly braces there: $value->$property.

remove the unneeded {/} in 22300.diff

Can someone remove the extra patch file? The .2 and .2.2 are the same file.

Thanks for the patch, wpmuguru!

The two functions look really similar to me. I think we should have a common map_deep() and these two will just return map_deep( 'urldecode', $value) and map_deep( 'rawurlencode', $value ).

Something like map_deep(), while it could have a few other use cases in core, could really slow down the deep mapping it is trying to do.

Actually, in my testing map_deep() is around twice faster for me for non-literal string values. I have no explanation.

Here is a very lame and crude testing script:

​https://gist.github.com/ac7c4d5f783880917758

I tried with op-code cache on and off, also I tried swapping the order of running the urldecode_deep/map_deep, I also tried using different functions, not only urldecode().

There is a chance I did some stupid mistake in the script, so I'd love a second look.

I get PHP Warning: urldecode() expects parameter 1 to be string, array given in /home/scribu/Desktop/bench.php on line 19 when running bench-map-deep.php

This wasn't affecting how the script worked. I fixed it, though.

I reversed the order in which the loops are done (rawurldecode_deep first) & the loop executed first is still about 3 times faster than the second loop.

I do think the map_deep function does have merit though as WP has a few other *_deep functions. map_deep would be something plugin & theme devs would be able to use.

It turned out that the idea of running them sequentially wasn't so good. I tested some more and the final result was that there is almost zero difference. Which means we should go ahead with the map_deep().

Here is a patch for the introduction of map_deep() and converting all older *_deep() functions to using it.

All the old tests pass and ​here are some for map_deep().

+1 for map_deep().

Every time I see this, I think is says "mad deep"

The path from map_deep() to "mad deep", to "truly, madly, deeply" isn't very long.

map_deep.diff looks good.