Opened 7 months ago
Closed 4 weeks ago
#22306 closed defect (bug) (fixed)
Some other string tweaks
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.6 |
| Component: | I18N | Version: | 3.4 |
| Severity: | normal | Keywords: | has-patch 3.6-early commit |
| Cc: | pavelevap@…, xoodrew@… |
Description
There are some other string tweaks: removing duplicate strings, removing HTML from strings, adding
"WordPress ›" to title as usual, using the same string where possible, etc. As a result, there are less strings to translate and several shorter strings to translate. Please see attached patch for detailed ideas.
Attachments (5)
Change History (21)
comment:1
SergeyBiryukov — 7 months ago
- Milestone changed from Awaiting Review to 3.5
comment:3
MikeHansenMe — 6 months ago
- Owner set to nacin
- Resolution set to fixed
- Status changed from new to closed
In 22430:
I left out a few changes:
- Did not see the need to add "a" to the ubiquitous "error establishing database connection" message.
- I didn't want to break a bunch of long and long-standing strings a month left in the cycle just to remove some HTML from them.
- Resolution fixed deleted
- Status changed from closed to reopened
- Did not see the need to add "a" to the ubiquitous "error establishing database connection" message.
Because we have the same string with "a" and without "a". I removed "a" in other places in updated patch.
- I didn't want to break a bunch of long and long-standing strings a month left in the cycle just to remove some HTML from them.
I do not think that one month is a big problem for translators. These strings contain the same sentences which can be then removed from localization files and there will be less work for translators in the end (only some of them were changed by removing HTML). I understand your reasons, but in this case we should not close this ticket?
I added some other little tweak in updated patch (removing double space).
I'd rather not remove markup if it means breaking one string into two.
comment:10
DrewAPicture — 6 months ago
- Cc xoodrew@… added
Looks like I'm late to the party, but I'd argue that use of <strong> or <em> tags inside a translatable string provides valid context for what requires emphasis.
I believe @otto42 may have touched on this in a recent blog post though this instance may not fall into what he'd consider a "rare" case where emphasis is warranted.
comment:11
follow-up:
↓ 14
SergeyBiryukov — 6 months ago
- Keywords 3.6-early added
Per the IRC chat, 22306.4.patch can be done early next cycle.
comment:12
SergeyBiryukov — 6 months ago
- Version changed from trunk to 3.4
comment:13
SergeyBiryukov — 5 months ago
- Milestone changed from Future Release to 3.6
comment:14
in reply to:
↑ 11
DrewAPicture — 5 weeks ago
Replying to SergeyBiryukov:
Did you still want to try to get this in for 3.6 or again wait for 3.7 early?
comment:15
SergeyBiryukov — 5 weeks ago
- Keywords commit added
comment:16
nacin — 4 weeks ago
- Resolution set to fixed
- Status changed from reopened to closed
In 24058:

Patch is simple enough +1 for commit.