show_home not working on wp_page_menu

[brasofilo]

As reported ​here, this function call doesn't returns the expected output:
wp_page_menu( array( 'show_home' => 'Hjem', 'sort_column' => 'menu_order' ) );

Looks like show_home is being ignored. It keeps outputting "Home" instead of the custom text and even setting it as false doesn't behave as expected.

If the filter wp_page_menu_args is used, wp_page_menu works correctly.

Tested in WordPress 3.4.2 and 3.5-beta2, no active plugins, using TwentyEleven.

The culprit is twentyeleven_page_menu_args() (twentytwelve_page_menu_args() in Twenty Twelve).

It ignores any passed value and enforces true instead:
http://core.trac.wordpress.org/browser/tags/3.4.2/wp-content/themes/twentyeleven/functions.php#L372

22331.patch​ is a fix for all three themes.

Using isset instead of empty

22331.2.patch​ uses isset instead of empty which also allows 'show_menu' => false with wp_page_menu.

Good call, thanks.

In 22359:

Bundled Themes: allow show_home argument to be overridden when using wp_page_menu as a fallback to a Custom Menu. Props SergeyBiryukov and kovshenin, fixes #22331.