WordPress.org

Make WordPress Core

Opened 8 months ago

Closed 3 months ago

#22366 closed defect (bug) (fixed)

Twenty Eleven: Set non-WP images to max-width 100%

Reported by: obenland Owned by: lancewillett
Priority: normal Milestone: 3.6
Component: Bundled Theme Version:
Severity: normal Keywords: has-patch commit
Cc: philiparthurmoore, xoodrew@…, knut@…

Description

If an image doesn't have a WordPress-generated class, we should be able to safely set its max width value to 100%. If the image does have a WP-generated class, we can leave it at 97.5% to accommodate border and padding rules.

Attachments (2)

22366.diff​ (779 bytes) - added by obenland 8 months ago.
22366.2.diff​ (934 bytes) - added by lancewillett 3 months ago.

Download all attachments as: .zip

Change History (11)

comment:1 DrewAPicture — 8 months ago

Seems reasonable enough, as long as we don't do it inline.

obenland — 8 months ago

comment:2 obenland — 8 months ago

  • Keywords has-patch added; needs-patch removed

comment:3 follow-up: lancewillett — 7 months ago

  • Milestone changed from Awaiting Review to Future Release

I think we should implement this on WP.com first, then let it soak in a while.

Recommend fixing 3.6 early.

comment:4 in reply to: ↑ 3 DrewAPicture — 7 months ago

  • Cc xoodrew@… added

Replying to lancewillett:

I think we should implement this on WP.com first, then let it soak in a while.

Recommend fixing 3.6 early.

Seems sensible. Let's do that.

comment:5 knutsp — 7 months ago

  • Cc knut@… added

comment:6 lancewillett — 4 months ago

  • Milestone changed from Future Release to 3.6

comment:7 lancewillett — 3 months ago

  • Keywords commit added

This has been working on WP.com for 2 weeks, should be safe to commit to core since no issues reported.

lancewillett — 3 months ago

comment:8 lancewillett — 3 months ago

Patch also adds better handling for images inside captions, fixing misalignment.

comment:9 lancewillett — 3 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23654:

Twenty Eleven: set images without WordPress-generated class to 100% maximum width, and fix spacing of images within caption containers. Props obenland, fixes #22366.

Note: See TracTickets for help on using tickets.