Gallery overlay controls disappearing

[johnbillion]

If you've inserted a gallery into your post and you click the gallery placeholder in the Visual editor, the 'Edit Gallery' and 'Delete Gallery' buttons appear, but they disappear again after about 4 seconds. They should be persistent while the gallery placeholder is selected.

Reproduced in 3.4.2 as well.

Would be a good thing to fix. Should be a matter of removing the timeout (and probably just always showing them).

In 22652:

Media: Make TinyMCE attachment and gallery controls always show when the corresponding view is selected. props SergeyBiryukov. fixes #22463, see #21390.

This shows these buttons even when the new media modal is opened and as they have higher z-index, they are on top.

To truly hide the buttons when a gallery or an image is deselected, this would need to be looking at blur for the image which is a bit tricky in contenteditable.

In 22857:

TinyMCE: improve hiding of the image/gallery popup buttons, fix selecting a gallery in IE, don't leave empty paragraph after deleting an image with the popup button, fixes #22463, see #21390

Uh, my bad. Should have added a patch as we are in RC :(

If we are changing when the popup buttons are shown, perhaps can show them on mouseover (after short delay)? That will ensure hiding them on mouseout. Another option would be to always show them although that won't look very good on images.

_hideButtons() uses tinymce.DOM.hide() and passes an array with element IDs to it, however if none of the elements exist on the page, it throws an error.

22463-2.patch fixes _hideButtons() by using Sizzle to pre-select the elements.

Also tested by SergeyBiryukov.

In 22883:

Editor: When hiding gallery/image editing buttons, use Sizzle rather than TinyMCE's internal DOM object. Avoids errors in case the elements do not exist, such as in Press This. props azaozz. fixes #22463.