Opened 7 months ago
Closed 7 months ago
#22468 closed defect (bug) (fixed)
Twenty Twelve: arrow in reply text renders poorly
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.5 |
| Component: | Bundled Theme | Version: | 3.5 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | kovshenin, drewstrojny |
Description
The "Reply" links in the Twenty Twelve theme all look like they are followed by some random garbage characters. They look more like arrows in Twenty Eleven, and they don't appear at all in my own theme. I'll attach some screen shots.
Attachments (7)
Change History (23)
miqrogroove
— 7 months ago
miqrogroove
— 7 months ago
miqrogroove
— 7 months ago
miqrogroove
— 7 months ago
comment:1
nacin
— 7 months ago
Are you using Windows XP font smoothing? Or rather, why aren't you? (And, why XP?)
comment:2
miqrogroove
— 7 months ago
The &darr code can be found in the twentytwelve_comment() callback where it uses comment_reply_link(). Currently, http://core.trac.wordpress.org/browser/trunk/wp-content/themes/twentytwelve/functions.php#L311
I am using XP because I like it, and my computer is ancient. Font smoothing makes the text blurry and annoys me.
comment:4
lancewillett
— 7 months ago
I vote "wontfix" on this, works fine in the vast majority of browsers and OS versions.
comment:5
helenyhou
— 7 months ago
I think it's more that the underline combined with the down arrow, which descends below the baseline, looks a little weird, even in more modern combinations.
comment:6
miqrogroove
— 7 months ago
helenhou are there other browsers/OS examples you could screen shot?
comment:7
helenyhou
— 7 months ago
I'm on OSX. It looks like it does in your iPad screenshot, except not HiDPI.
comment:8
miqrogroove
— 7 months ago
On OSX does it look the same in all browsers? Maybe 1 or 2 screen shots would help.
comment:9
lancewillett
— 7 months ago
- Cc drewstrojny added
@drewstrojny What do you think about removing the underline or arrow here?
comment:10
drewstrojny
— 7 months ago
I'd say remove the arrow if it's causing issues. The basic link works just fine.
comment:11
miqrogroove
— 7 months ago
Just a thought: comment_reply_link() offers an "after" argument. Move the arrow after the link, as seen here on Trac?
miqrogroove
— 7 months ago
comment:12
miqrogroove
— 7 months ago
Patch attached for clarity. Uncertain if arrow requires translation though.
comment:13
lancewillett
— 7 months ago
- Milestone changed from Awaiting Review to 3.5
Nope, since it's a down arrow it doesn't need to be translated. (Left or right would for RTL languages.)
comment:15
lancewillett
— 7 months ago
- Summary changed from Twenty Twelve's &darr Renders Poorly to Twenty Twelve: arrow in reply text renders poorly
comment:16
lancewillett
— 7 months ago
- Owner set to lancewillett
- Resolution set to fixed
- Status changed from new to closed
In 22614:
WinXP Screen Shots