wp_mime_type_icon() fails to properly cache icons
|Reported by:||nacin||Owned by:||nacin|
It does this:
$icon_files = wp_cache_get('icon_files');
wp_cache_set('icon_files', $icon_files, 600);
See the issue? I spent an embarrassing amount of time debugging the caching backend before I did. The timeout of "600" is actually the cache group in that call. We need to slip in a 'default' there.
Noticed while doing profiling for #22186. If you're calling this function for a whole bunch of attachments, all of those repetitive disk scans can slow things down quite a bit.