Insert Media: Non-image attachments aren't inserted with a link

[ocean90]

• Upload a PDF file
• Select Linkt to and use one of the options, for example Media File
• Click Insert into post

Only the title will be inserted, the link around the text is missing.

​http://wordpress.org/support/topic/new-media-insert-only-images-work-no-other-files-like-pdfs-etc?replies=1

Confirmed.

Define $_POST['url'] for non-image attachments in wp.media.editor.send.attachment().

Looking at this, I think we should go back to the old field names used by media_upload_form_handler() — align, image_alt, image-size, post_excerpt, post_title. Here's a patch that does that while fixing both this ticket and #22553.

Sidenote: $_POST['attachment']['url'], not $_POST['url'].

An empty line is inserted with 22553.diff. 22544.diff works. (Chrome, Mac OS)

Will handle the other stuff in #22553.

In 22835:

Media: Include the link URL when inserting non-image attachments. props koopersmith. fixes #22544.