Opened 6 months ago
Closed 6 months ago
#22554 closed defect (bug) (fixed)
New media: Long file names overflow container
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.5 |
| Component: | Media | Version: | 3.5 |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: |
Description
As per description.
Attachments (3)
Change History (16)
johnbillion — 6 months ago
comment:1
in reply to:
↑ description
Nasarullahmari — 6 months ago
- Keywords reporter-feedback added
- Type changed from defect (bug) to feature request
comment:2
SergeyBiryukov — 6 months ago
- Keywords reporter-feedback removed
- Type changed from feature request to defect (bug)
comment:3
koopersmith — 6 months ago
- Keywords needs-patch added
Ah. This is due to removing the overflow: hidden; on the attachment view.
comment:4
koopersmith — 6 months ago
- Milestone changed from Awaiting Review to 3.5
comment:6
miqrogroove — 6 months ago
Does break-word actually work? I tried using it recently to no avail.
Hello.
includes/css/media-views.css - line 561:
.attachment .filename {
/*...*/
overflow: hidden;
text-overflow: ellipsis;
}
This works, but imho this is not the best thing to do because we can see only 10 characters at best. I think this is a better way:
.attachment .filename {
/*...*/
overflow: hidden;
word-wrap: break-word;
max-height: 99px;
}
This way we can see longer file names. (the max-height is for veeeeeery long file names)
koopersmith — 6 months ago
comment:8
koopersmith — 6 months ago
Patch provides better handling for long filenames (no overflow, break word, fit within container, etc).
comment:9
in reply to:
↑ 7
koopersmith — 6 months ago
- Keywords has-patch added; needs-patch removed
Replying to GregLone:
Hello.
Hi, GregLone, and welcome! In the future, instead of providing specific code changes in a comment, please create a patch. Patches make it much easier for other developers to apply and test your changes consistently.
I've converted some of your suggestions into a patch (with improvements to the max-height section, as the size of the grid is dynamic).
comment:10
nacin — 6 months ago
What is left here? Basic testing across all the browsers down to IE8 or so?
comment:11
koopersmith — 6 months ago
Firefox has a relatively minor sad.
koopersmith — 6 months ago
comment:12
koopersmith — 6 months ago
- Keywords commit added
Fixes titles in Chrome, Firefox, Safari, Opera, and IE.
comment:13
ryan — 6 months ago
- Owner set to ryan
- Resolution set to fixed
- Status changed from new to closed
In 22870:

Replying to johnbillion:
Its nice hear about you,i am new here in this disscussions,
hope we good interaction in future wd eachother.
Many thnkx.