WordPress.org

Make WordPress Core

Opened 7 months ago

Closed 7 months ago

Last modified 7 months ago

#22561 closed defect (bug) (invalid)

Unnecessary show_in_menu check in menu.php

Reported by: ocean90 Owned by:
Priority: normal Milestone:
Component: Administration Version:
Severity: normal Keywords:
Cc:

Description (last modified by ocean90)

get_post_types( array( 'show_in_menu' => true ) doesn't return an object, where show_in_menu is false.

Attachments (1)

22561.patch​ (727 bytes) - added by ocean90 7 months ago.

Download all attachments as: .zip

Change History (4)

ocean90 — 7 months ago

comment:1 ocean90 — 7 months ago

  • Description modified (diff)

comment:2 SergeyBiryukov — 7 months ago

  • Keywords 3.6-early removed
  • Milestone Future Release deleted
  • Resolution set to invalid
  • Status changed from new to closed

Introduced in [15844].

show_in_menu can also be a string, e.g. 'tools.php' or 'edit.php?post_type=page'. In that case, the post type item will become a submenu of the corresponding top level menu item.

The patch would break that.

comment:3 ocean90 — 7 months ago

  • Keywords has-patch removed

Oops!

Note: See TracTickets for help on using tickets.