#22610 closed defect (bug) (fixed)
Media Uploader Selected File Icons
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.5 |
| Component: | Media | Version: | 3.5 |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: |
Description
Icons to replace the unicode symbols in the new media uploader in 3.5 for selecting and deselecting images, as well as the close modal window (X) icon.
Attachments (21)
Change History (46)
JerrySarcastic — 6 months ago
comment:1
SergeyBiryukov — 6 months ago
- Version set to trunk
comment:3
JerrySarcastic — 6 months ago
Happy to iterate on the design, but the "fuzziness" looks better against the background. Here they are in context. :)
22610.diff should get these mostly in place (may need a few pixel nudges).
uploader-icons.png & uploader-icons-2x.2.png have been imageoptim'd.
comment:5
JerrySarcastic — 6 months ago
Oops, beat me to it Dave. :)
comment:7
JerrySarcastic — 6 months ago
New 1x icons, as sharp as can be. :)
JerrySarcastic — 6 months ago
comment:10
helenyhou — 6 months ago
- Keywords has-patch needs-ui added; needs-patch removed
Need a source file for design/asset repo. If the 1x versions were hand-tweaked, please include those in the source file as well.
comment:11
JerrySarcastic — 6 months ago
- Keywords needs-ui removed
Zipped these up so it would be less confusing. These have both been optipng'd
comment:12
koopersmith — 6 months ago
As per IRC, JerrySarcastic is adding two x icons with the same treatment as the check and dash.
JerrySarcastic — 6 months ago
comment:13
JerrySarcastic — 6 months ago
Should note: Both attached sprites expanded to add X icons. :)
comment:14
follow-up:
↓ 20
helenyhou — 6 months ago
22610.4.diff adds the x icon for removal of an item from the gallery edit view. Needs somebody to check on the icon placement in 2x for all of the above - ideally it would line up correctly so background-position doesn't need to be altered in the media query.
comment:16
ryan — 6 months ago
Looking good on Retina MacBook.
comment:17
ryan — 6 months ago
- Owner set to ryan
- Resolution set to fixed
- Status changed from new to closed
In 22919:
comment:18
ryan — 6 months ago
In 22920:
JerrySarcastic — 6 months ago
JerrySarcastic — 6 months ago
comment:19
JerrySarcastic — 6 months ago
PNG files updated to fix image alignment of the remove (X) icons
JerrySarcastic — 6 months ago
JerrySarcastic — 6 months ago
JerrySarcastic — 6 months ago
comment:20
in reply to:
↑ 14
;
follow-up:
↓ 22
JerrySarcastic — 6 months ago
uploader-icons-2x.5.png fixed to center the remove (x) icon. Tested and works.
uploader-icons.4.png does the same, but needs to be tested.
comment:21
SergeyBiryukov — 6 months ago
- Resolution fixed deleted
- Status changed from closed to reopened
comment:22
in reply to:
↑ 20
lessbloat — 6 months ago
Replying to JerrySarcastic:
uploader-icons-2x.5.png fixed to center the remove (x) icon. Tested and works.
uploader-icons.4.png does the same, but needs to be tested.
These look good on my Retina screen (I'm on the road, so I don't have a non-HiDPI screen to test on).
comment:23
ryan — 6 months ago
- Resolution set to fixed
- Status changed from reopened to closed
In 22939:
comment:24
ryan — 6 months ago
In 22940:
comment:25
helenyhou — 5 months ago
Sources committed in [D11].

These look nice, although of course need to see them in context. The 1x black dash seems a little fuzzier than the others, though.