Opened 6 months ago

Closed 6 months ago

#22615 closed defect (bug) (fixed)

Responsive css for the media modal

Reported by: azaozz Owned by:
Priority: low Milestone: 3.5
Component: Media Version: 3.5
Severity: normal Keywords: audit needs-patch
Cc:

Description

The current goal is to make the new media modal work/look well on tablets and small-screen laptops (same as the rest of the admin).

Attachments (6)

22615.patch (2.3 KB) - added by azaozz 6 months ago.
22615-2.patch (2.3 KB) - added by azaozz 6 months ago.
22615.3.patch (438 bytes) - added by ocean90 6 months ago.
22615.4.diff (2.8 KB) - added by koopersmith 6 months ago.
22615.4b.diff (2.8 KB) - added by ocean90 6 months ago.
22615.5.diff (3.2 KB) - added by ocean90 6 months ago.

Download all attachments as: .zip

Change History (19)

azaozz6 months ago

azaozz6 months ago

In 22615-2.patch:

  • At 900px width reduces the width of the left and right areas and reorders the image options so labels ate above the fields.
  • 600px is the min-width. The modal has position: absolute so it can be scrolled horizontally.
  • Includes couple of fixes for 22615.patch
Last edited 6 months ago by azaozz (previous) (diff)
  • Keywords has-patch commit added

Good start.

  • Keywords dev-feedback added

Concur. Commit, mark as see, bump to low priority.

  • Keywords dev-reviewed added; dev-feedback removed

...things that begin with "dev".

In 22887:

Responsive CSS for the media modal. props azaozz. see #22615, #21390.

  • Keywords has-patch commit dev-reviewed removed
  • Priority changed from normal to low
  • Keywords has-patch added

22615.3.patch improves the media selection in the toolbar.

attachment:22615.4.diff builds off of​​ attachment:22615.3.patch:

Needs RTL after the current patch on #22453 is committed.

  • Tweaks media selection improvements, moves them to the earlier break point.
  • Adjusts modal size, dashed line position, separator size, padding on sidebar, and menu size.

attachment:22615.5.diff​ adds a lot of RTL stuff. And refreshes 22615.4.diff​. And looks good.

(Except that the search form isn't bumped quickly enough.)

22615.5.diff looks good. The only thing I've noticed is the rounded search field in iOS, but that's the same as other search fields in the admin.

In 22960:

Responsive and RTL css improvements or the media modal.

Props ocean90, koopersmith
see #22615

  • Keywords audit needs-patch added; has-patch removed

This ticket is basically just open for any additional cleanups or adjustments we want to make; it's a rider.

  • Resolution set to fixed
  • Status changed from new to closed

If ocean90 or azaozz has anything else here, please re-open. Thanks.

Note: See TracTickets for help on using tickets.