plugin_basename() fails on case-sensitive plugin directories

[bungeshea]

When WP_PLUGIN_DIR has slightly different casing to the actual path, plugin_basename() returns the full path to the plugin file.

For example:

If WP_PLUGIN_DIR is set to C:/Website/wp-content/plugins, but the actual file-system path is C:/Website/wp-content/Plugins, plugin_basename() will return the full path to the plugin file.

The plugin_basename() function uses a preg_replace statement to find path to the plugin relative from WP_PLUGIN_DIR. If the actual path to the plugin directory does not match case to WP_PLUGIN_DIR, the preg_replace will fail. This is because preg_replace is not case sensitive.

Replying to bungeshea:

The plugin_basename() function uses a preg_replace statement to find path to the plugin relative from WP_PLUGIN_DIR. If the actual path to the plugin directory does not match case to WP_PLUGIN_DIR, the preg_replace will fail. This is because preg_replace is not case sensitive.

I think you mean it is case sensitive. This makes sense, since on every platform except Windows, paths are case sensitive.

Maybe this could be changed to be insensitive on Windows, but for most platforms, this is the correct behaviour.