wp_editor() on front end adds stylesheet to page

[itworx]

Seems wp_editor is adding a stylesheet to posts when inserted on front end. These styles override theme styles for .button ++

<link rel='stylesheet' id='buttons-css' href='​http://mysite.com/themename/wp-includes/css/buttons.min.css?ver=3.5-RC2' type='text/css' media='all' />

We knew this bug report would come eventually.

The plan of attack that comes to mind for me:

• Keep buttons.css in the admin only.
• Have our own button classes and styles for the media modal that can work on the frontend. Probably .wp-button or even .wp-media-button.

I know koopersmith and helenyhou have spoken — what's the verdict?

Something else, as presented in ​IRC :) A container/scoping class, let's say .wp-core-ui. So, body.wp-core-ui for the admin, .wp-core-ui on wrappers for things that can be used outside the admin itself but use styling provided by core (WP_Editor, media).

Koop is doing an extra check for any other places where we may need the class, and any other realizations are more than welcome. 22644.diff​ as a start, though.

Added a bit to make sure .wp-core-ui is always set in new media. Ready to go.

We need more! setup-config, install, upgrade, media-upload, and customize all need love.

This should cover just about everything.

ack --php '<body'

Also updates the .welcome-button to use the .button-hero size instead.

Couldn't see any issues with 22644.3.diff. Tested also on a page template for Twenty Eleven with:

<?php wp_editor('Test content', 'frontend_editor'); ?>
<input type="button" class="button" value="Button" /><br/>
<a href="#" class="button">Link</a>

In 22948:

Scope button classes so they can be used on the frontend without interfering with theme styles.

Props helenyhou, koopersmith
fixes #22644