Opened 6 months ago
Closed 6 months ago
#22713 closed defect (bug) (fixed)
Media: Hide "Edit" link in the selection view when it doesn't make sense
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.5 |
| Component: | Media | Version: | 3.5 |
| Severity: | normal | Keywords: | has-patch needs-testing commit |
| Cc: |
Description
Say you are selecting attachments in the media dialog. There is an "Edit" link next to "Clear" and "X selected". It should not always show.
A selection should not be editable when:
- You are creating a gallery, as to edit it, you should actually create the gallery. (For this, we should declare the view as not editable.)
- You have only one item selected. (This should probably happen via CSS.)
Attachments (3)
Change History (11)
- Keywords commit added
- Owner set to koopersmith
- Status changed from new to assigned
comment:2
miqrogroove — 6 months ago
comment:3
koopersmith — 6 months ago
- Keywords needs-refresh needs-body added; commit removed
Doesn't apply cleanly.
comment:4
koopersmith — 6 months ago
- Keywords commit added; needs-refresh needs-body removed
Nevermind. Problem on my end.
koopersmith — 6 months ago
comment:5
koopersmith — 6 months ago
- Keywords needs-testing added; commit removed
Patch fixes all 3 cases, updates RTL CSS.
Note: See
TracTickets for help on using
tickets.
# 3: While editing, there is no need for an Edit link because it doesn't do anything.