Exiting new media modal pushes user to bottom of page in Firefox

[tomthewebmaster]

When exiting the new media modal in Firefox 17.0 on a Mac, I am pushed to the bottom of the screen. Steps to reproduce:

• Open a new post ("Add New Post")
• Press "Add Media"
• Press the upper-right-hand "x" to close the media window

At this point, one's page is pushed to the bottom, regardless of where the page position was prior to opening the media modal. I'm not sure this is intended behavior, as this doesn't happen in most other browsers. I believe I also saw this once in Safari 6.0.2 but was not able to do again.

[nacin]

I know helenyhou uses Firefox, and she has not reported this. Try checking plugin conflicts?

[DrewAPicture]

I can reproduce this closing the modal via both QuickPress and the post editor in Firefox. It's similar behavior to what I noted in the second bullet point in comment:ticket:21776:48, only in this case there's no hash being appended to the URL.

[DrewAPicture]

A short screencast to illustrate the point: ​http://screencast.com/t/nv4aQsAGFRLc

[tomthewebmaster]

All plugins are disabled.

[tomthewebmaster]

Replying to tomthewebmaster:

When exiting the new media modal in Firefox 17.0 on a Mac, I am pushed to the bottom of the screen. Steps to reproduce:

• Open a new post ("Add New Post")
• Press "Add Media"
• Press the upper-right-hand "x" to close the media window

At this point, one's page is pushed to the bottom, regardless of where the page position was prior to opening the media modal. I'm not sure this is intended behavior, as this doesn't happen in most other browsers. I believe I also saw this once in Safari 6.0.2 but was not able to do it again.

[helenyhou]

I can reproduce, but it must be pretty new unintentional behavior. Definitely had not noticed it before. Happens on any screen, with any method of closing the modal, including insertion or setting the featured image.

[koopersmith]

Actually, it appears that it's happening on open, not close. Watch the page behind the modal.

[johnkleinschmidt]

Focus patch

[koopersmith]

Thanks for the patch, johnkleinschmidt. Unfortunately, removing .focus() is insufficient, as that will break keyboard shortcuts.

[koopersmith]

attachment:22716.2.diff​ records the original scroll position of the window and restores the scroll position on close. It also locks scrolling on the document, so scrolling in the modal will not scroll the document.

[DrewAPicture]

22176.2.diff fixes it for me.

[sabreuse]

Fixes it for me too.

[johnkleinschmidt]

I figured there was a good reason for the focus call and didn't think about needing it for keyboard shortcuts.

Your patch fixes it for me too.

[helenyhou]

Works for me in FF. Tested in iPad for fun, with no ill effects noted, although you can still scroll the document there.

[ocean90]

Suprise: Fixes it for me too. (Also no side effects in IE)

[markjaquith]

Fixes it. No ill effects in Chrome. Locks scrolling of background document in Chrome and FF (which is a win for a serious annoyance!).

[markjaquith]

In 23029:

Fix a Firefox "scroll to bottom" bug when launching the media modal.

• Records main document scroll position when launching media modal.
• Restores position when media modal is closed.
• Also locks background document scrolling while media modal is open, preventing inadvertent scrolling there.

props koopersmith. fixes #22716

[azaozz]

Some background: this was happening because when calling focus() the browser's built-in scrollIntoView kicks in and the modal is at the bottom of the page in the html. So the browser was mis-calculating the position/visibility of the modal and trying to scroll to it.