Create Gallery Shouldn't Say "All media"

[miqrogroove]

I'm still extremely confused by the presence of the two different Library tabs in the new media modal. Here's a specific problem with them:

They both have an option called "All media items" that appear to do completely different things to the library view.

Galleries can only contain images, so I imagine that's what it's filtering. Perhaps the filter dropdown shouldn't say "All media items" but rather "Images".

It is actually much better for the user that they can only select items that can actually go into a gallery. Would be much worse if they could select audio or PDFs that won't show in the end result.

22722.diff​ switches "All media items" to "All images" in the Gallery, and the Featured Image view.

Two things. First, we should probably use just "Images", as the "add to gallery" library only shows images not in the gallery (so, not *all* images) and "All images" is a new string. Second, this view is not tailored for images alone (it just so happens that we use it with image queries), so "all images" may be inaccurate if applied directly to the view.

attachment:22722.2.diff​ uses the correct string based on the query's mime type and whether the mime type string is available.

+1 to 22722.2.diff​. Works well.

In 23041:

When adding images to a gallery, use "Images" as the filter name, rather than "All media items". props koopersmith. fixes #22722.

Filter name "Images" should be also used in "Add to Gallery" tab for consistency?

This should be fixed when #22723 is.

In 23068:

Fix the "Uploaded to this post" filter in the "Add to gallery" state. fixes #22723

Also, use "images" wording instead of generic "media items" when in a gallery (images-only) context. fixes #22722

Both are props koopersmith