Media in IE: Upload dialog still pop ups even when you're in library view

[ocean90]

• Open the media modal
• Have in mind where the Select Button is
• Switch to the library view
• Click near the place where the button was before
• Upload dialog pop ups :(

Can anyone else confirm this behavior as well?

Comfirmed in IE9.

Also when you right click there, you get a 'sliverlight' dialog. Methinks it may be an issue of silverlight overlaying something and it not getting stashed.

Confirmed in IE 7 and 8. I don't have Silverlight installed, so I get a Flash menu on right click.

Moreover, Media Library doesn't seem to work at all in IE 7. The media modal content is blank: 22732.media-library-ie7.png​. Works fine in IE 8 though.

Hmm... I can't seem to be able to replicate this in IE7 or IE8.

I can however verify that the media library is showing a blank screen in IE7.

1, 2, 3… FIGHT.

Also, opening the media modal and closing it with no changes leads to "Are you sure you want to leave this page" warning when pressing F5 or trying to go to another screen in both IE 7 and 8.

IE 7 and 8: From URL - When pasting an image URL into the field nothing happens.

22732.diff​ is a quick stab at getting us mostly back on course with IE7 media library.

Replying to ocean90:

IE 7 and 8: From URL - When pasting an image URL into the field nothing happens.

It appears to work for me in both.

Perhaps we should add an .ie7 class to the modal like we do for #wpadminbar? That would avoid the css hacks.

22732.diff​ appears to fix the Media Library in IE 7.

However, thumbnails are much larger in IE 7 (only 3 columns vs. 7 columns in IE 8), see 22732.media-library-ie7.2.png​ and 22732.media-library-ie8.png​. Not sure if that's intentional.

Replying to SergeyBiryukov:

However, thumbnails are much larger in IE 7

IE7 doesn't appear to be auto-resizing the sizes based on the width of the browser. 22732.2.diff​ changes the default width/height from 199px/199px to 120px/120px.

22732.2.diff​ looks good to me.

"From URL" looks weird in IE 7: 22732.from-url-ie7.png​. Aside from scrollbars, "Upload Files" and "Media Library" tabs should not be there.

Replying to azaozz:

Perhaps we should add an .ie7 class to the modal like we do for #wpadminbar? That would avoid the css hacks.

Done in 22732.3.diff.

Replying to SergeyBiryukov:

"From URL" looks weird in IE 7: 22732.from-url-ie7.png​. Aside from scrollbars, "Upload Files" and "Media Library" tabs should not be there.

Scroll bars and margin should be fixed in 22732.4.diff​. I'm not seeing the "Upload Files" and "Media Library" tabs. Here's what I see:

Tested the uploading bug fairly thoroughly in IE8. attachment:22732.upload.2.diff​ fixes it for me.

Turns out that while the shim doesn't open the modal, the overlay is still there. How fun.

Tested with IE8, using the HTML4, Silverlight and Flash runtimes.

Tested with IE9, using the HTML4 and Silverlight runtimes.

Commit attachment:22732.upload.4.diff​ — leave open and lower priority for the IE7 fixes.

In 23053:

Toggle display of plupload overlays when the select files button is hidden. see #22732.

22732-5.patch is similar to 22732.4.diff​ but has alternative layout fix for IE7. Both patches add smaller default size for the thumbnails for IE7 relying on the resizing JS not working there.

Two minor tweaks in 22732-6.patch:

• Added 4px margin-top to "From URL" text box
• Added align: left to .link-to-custom which shows up under the "Link to" drop down.

Other than that, 22732-5.patch​ looks great.

22732-6.patch​ looks good here too, +1 to commit.

In 23061:

Media IE7 fixes. props azaozz, lessbloat. fixes #22732.