#22757 closed defect (bug) (fixed)
load-scripts.php is receiving too long of a GET parameter
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | high | Milestone: | 3.5 |
| Component: | Administration | Version: | 3.5 |
| Severity: | blocker | Keywords: | has-patch needs-testing |
| Cc: |
Description
This was originally reported here: http://wordpress.org/support/topic/flyout-menus-35-rc12.
This works:
This does not:
Obviously, error reporting would normally be suppressed in load-scripts.php, but that'd only end up with a blank page and thus most of the JavaScript on the screen breaking. $_GET['load'] is being unset for length reasons. Why? I don't know yet. I can reproduce this exact length issue on my nacin.com server too, so going to dig there next.
Add one more character to the first URL and it will fail.
Attachments (4)
Change History (12)
- Keywords has-patch needs-testing added
22757.diff is a very ugly (and not at all efficient) patch that works.
comment:3
georgestephanis — 6 months ago
Shouldn't
if ( strlen( $concat ) + strlen( $script ) > 513 ) {
be > 511 as the comma isn't included between the two?
georgestephanis — 6 months ago
georgestephanis — 6 months ago
comment:4
georgestephanis — 6 months ago
22753.3.diff is functionally the same as 22753.2.2.diff, but I didn't correct whitespace style around it to simplify the patch.
22757.2.diff looks good.
- Turn off SCRIPT_DEBUG
- Load an admin page
- Look at load-scripts.php requests
- Verify proper chunking. No off by one, no lists out of order.
- Console is error free
- All the js goodness seems to be present and working
22757.2.diff looks good to me; no missing or out-of-order scripts with some of our script-heavier plugins.
- Owner set to nacin
- Resolution set to fixed
- Status changed from new to closed
In 23074:
suhosin.get.max_value_length = 512 is the default. We need to chunk this.