WordPress.org

Make WordPress Core

Opened 7 months ago

Last modified 5 months ago

#22799 new defect (bug)

Erase Formatting Doesn't erase

Reported by: RDall Owned by:
Priority: normal Milestone: 3.6
Component: TinyMCE Version: 3.4
Severity: normal Keywords: has-patch needs-testing
Cc: mdhansen@…

Description

In the Content area of a page under the visual test manager of a page if you highlight text click the bold button add italics and cross out. When I I highlight the text and then click the erase format button it only removes the italics and leaves the cross out.

On two other builds I have tested this problem with it turns the text red?

Have tested on two local installs. (one clean to test this issue) and one external install. All using Trunk all the same issue. See screenshot for visual reference.

http://cl.ly/image/1Y1I1H2u471E

Attachments (2)

Screen Shot 2012-12-06 at 3.40.24 PM.png (127.6 KB) - added by RDall 7 months ago.
Screenshot of issue on two different builds.
22799.patch (969 bytes) - added by azaozz 6 months ago.

Download all attachments as: .zip

Change History (13)

comment:1 nacin7 months ago

Is this reproducible in 3.4.2?

RDall7 months ago

Screenshot of issue on two different builds.

comment:2 helenyhou7 months ago

  • Keywords needs-patch removed

That looks like two different themes to me, probably styling stuff (markup) differently. What's the HTML/Text tab show? Screenshot of that is probably fine.

comment:3 helenyhou7 months ago

  • Keywords reporter-feedback added

comment:4 nacin7 months ago

Related, #21037.

comment:5 RDall7 months ago

Yes I was able reproduce the problem in 3.4.2 It will remove the bold and the italics but the strike through was not removed. I also checked the html version and all tags were removed but the strike through tag.

http://cl.ly/image/1X1i2c1K0v0A

Last edited 7 months ago by RDall (previous) (diff)

comment:6 nacin7 months ago

  • Version changed from trunk to 3.4

azaozz6 months ago

comment:7 azaozz6 months ago

  • Keywords has-patch needs-testing added; reporter-feedback removed
  • Milestone changed from Awaiting Review to 3.6

Since we use <del> tag for the Strikethrough button, we need to specify it as removable with the Remove Format button. This can be set in the formats init option. Also added there few of the deprecated elements that are supported with the patched html5 schema.

comment:8 azaozz6 months ago

#21037 was marked as a duplicate.

comment:9 MikeHansenMe6 months ago

  • Cc mdhansen@… added

Tested the patch and it works as expected w/ 3.6-alpha.

comment:10 SergeyBiryukov5 months ago

#23359 was marked as a duplicate.

comment:11 mark-k5 months ago

HTML5 defines strong, del and em as having semantic meaning and not a styling one. If all the editor does is styling then it should use style="font-weight:bold" instead of strong etc..

Looking at the patch the deletion of strong, em, del, and ins is wrong as it changes the meaning of the content.

Note: See TracTickets for help on using tickets.