Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#22808 closed defect (bug) (fixed)

Context for Text tab missing

Reported by: pavelevap Owned by: nacin
Priority: normal Milestone: 3.5
Component: I18N Version: 3.5
Severity: normal Keywords: needs-patch
Cc: pavelevap@…

Description

In 3.5 "HTML" tab was renamed to "Text" with proper context. But in DFW fullscreen window was this context missed. So, now we have two strings for "Text":

1) "Text" editor tab

2) "Text" editor tab in DFW + "Text" widget.

It is strange mix and problem for translators. See attached patch.

Attachments (1)

text_context.patch​ (798 bytes) - added by pavelevap 5 months ago.

Download all attachments as: .zip

Change History (8)

pavelevap — 5 months ago

comment:1   SergeyBiryukov — 5 months ago

  • Keywords has-patch added

comment:2   nacin — 5 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.5

comment:3   markjaquith — 5 months ago

+1. not a new string. Should have context.

comment:4   nacin — 5 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 23122:

Update fullscreen/DFW's "Text" tab to match the string context used for the editor Text tab. Not a string change. props pavelevap, fixes #22808.

comment:5   TobiasBg — 5 months ago

  • Keywords needs-patch added; has-patch commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

__ needs to be changed to _x here, otherwise the second parameter will be recognized as a text domain.

comment:6   nacin — 5 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 23123:

Ensure [23122] gets parsed as context. props TobiasBg. fixes #22808.

comment:7   pavelevap — 5 months ago

Ooops, sorry, stupid mistake :-(

Thank you for commit, really helpfull...

Note: See TracTickets for help on using tickets.