Massive Code Cleanup: streams.php, vars.php

[markjaquith]

The detail obcession continues.

As before, the bulk of the work consists of:

• spaces to tabs
• two newlines between functions
• brackets removed for one-line if ()s
• \t\n => \n
• [space]\n => \n
• \t[space] => \t
• no cramming two lines into one.
• if/else bracket tab matching
• foreach : endforeach; and if : else; are for front-of-house code only
• clean spacing for if, foreach, and for: if ( $condition ) {
• if ( $something == 'value' ) => if ( 'value' == $something ) as per coding guidelines

Also, vars.php was using preg_match and strstr for "does this string exist in that string" test. According to php.net, these should not be used for this purpose, as they are slower. The method to use is strpos($haystack, $needle) !== false

I convented the browser checks in vars.php to use this faster method.

Let's put this off until after 2.0.1.

Roger. As soon as we have a stable 2.0.x version, I'm going to do a major refactoring, before major work for 2.1 begins.

Out-of-date. Let's close this bug and continue the cleanups in a new bug.