Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#2283 closed defect (bug) (fixed)

Error in patch for https support will prevent absolute URL footnotes from working

Reported by: michaelmoore Owned by: anonymous
Priority: normal Milestone:
Component: General Version: 2.0
Severity: normal Keywords: bg|has-patch
Cc:

Description

The patches I submitted for https support which were incorporated in revision 3041 contain an error that will prevent URL footnotes with absolute URLs from being displayed properly. A further patch correcting the error is attached. Sorry.

Attachments (1)

revised-https-patch.php​ (847 bytes) - added by michaelmoore 7 years ago.
patch for 1 erroneous line in make_url_footnote from earlier https support patch

Download all attachments as: .zip

Change History (6)

michaelmoore — 7 years ago

patch for 1 erroneous line in make_url_footnote from earlier https support patch

comment:1   davidhouse — 7 years ago

  • Keywords bg|has-patch added

comment:2   matt — 7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3445]) Better HTTPS support - fixes #2283

comment:3   michaelmoore — 7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

It looks like the applied fix does not properly change "7" to "8" in the second occurance of "substr($link_url,0,8)" as indicated in the patch, which will cause absolute URL footnotes to https servers to still be incorrectly rendered. I am reopening this ticket instead of opening a new one since this ticket still applies to the problem. Thanks sincerely.

comment:4   ryan — 7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [3464]) 8 not 7. fixes #2283

comment:5   anonymous — 6 years ago

  • Milestone 2.0.1 deleted

Milestone 2.0.1 deleted

Note: See TracTickets for help on using tickets.