link-search-field float (RTL-Arabic)

[rasheed]

Link search field should be moved to right
+ General note about URL field.

(Screenshot attached)

Is this a 3.5 regression?

Same issue also in 3.4.2

Replying to nacin:

Is this a 3.5 regression?

Replying to rasheed:

Same issue also in 3.4.2

The URL alignment was also on 3.4.2, but the search box is 3.5 regression.

22835.patch​ also cleans up some obsolete and redundant styles.

Screenshot: 22835.after.png​

Also noticed a bug with the search input in Chrome similar to the one in #22935: 22835.chrome-search-input.png​.

Appears to be a Chromium bug, fixed two weeks ago: ​https://codereview.chromium.org/11421088/.

22835.2.patch​ fixes that as well using ::-webkit-textfield-decoration-container: 22835.chrome-search-input.2.png​.

Sergey, can you make the search input box wider? as wide as the URL input bux above?

And move the X on the top-right corner to the top-left corner.

Replying to ramiy:

Sergey, can you make the search input box wider? as wide as the URL input bux above?

Changed for both LTR and RTL in 22835.3.patch​. Screenshot: 22835.after.2.png​.

And move the X on the top-right corner to the top-left corner.

Also fixed in 22835.3.patch​.

Looks great!

22835.3.patch​ looks good, just would request that the ::-webkit-textfield-decoration-container piece be taken out so we address that universally instead.

Done in 22835.4.patch​

22835.4.patch​ makes the input so wide that the spinner is bumped to the next line. I don't think a search field needs to be full-width, let's bring it back to what it has been for now, for 3.5.

Replying to nacin:

I don't think a search field needs to be full-width, let's bring it back to what it has been for now, for 3.5.

22835.diff​

22835.diff​ keeps the current search input width.

In 23226:

RTL fixes for internal linking. props SergeyBiryukov, helen. see #22835, for trunk.

In 23274:

RTL fixes for internal linking. props SergeyBiryukov, helen.

merges [23226] to the 3.5 branch.
fixes #22835.