Opened 6 months ago
Last modified 4 months ago
#22869 new defect (bug)
Large Image Uploads Don't Error Well
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Awaiting Review |
| Component: | Media | Version: | 3.4 |
| Severity: | normal | Keywords: | |
| Cc: |
Description
Related to #22849 but not restricted to the new uploader. Happens on 3.4 and 3.5 in different ways.
To Reproduce: Upload https://objects.dreamhost.com/ipstenu-images/sunset_2_22_11_by_kenshinkyo-d3a6slk.jpeg to your WP install in the media-new.php page
Note: Image is 12600x9450 and 4.9MB
Expected Outcomes:
- Shared hosted without a lot of memory: Failure, not enough memory, no image uploaded.
- VPS/Dedicated with tons of memory: Success
Actual outcomes:
- VPS as expected.
- Shared not so much. You get the errors as expected however the failure is not correct. The image actually does upload, contrary to the errors, however no thumbnails are made, which then causes a memory problem as the full size image shows when you go to any media library view (in lieu of actual thumbnails). This crashed Chrome (as @markjaquith saw when we were testing Monday night) until I deleted the large images.
The actual issue is on thumbnail creation, so the best 'fix' I can think of is if on failed thumbnail gen, it nukes the master image, but I don't know if that would make sense since some of the thumbnail gen might be on extra image sizes set by themes/plugins. Then again, do you want those if all fail?

Erf. Happens on ALL media uploads, not just the media-new page (if someone could remove "to your WP install in the media-new.php page" from the description please and thank you)