WordPress.org

Make WordPress Core

Opened 6 months ago

Last modified 5 months ago

#22974 assigned defect (bug)

Media manager inaccessible when dragging several images on Safari

Reported by: mario-siteground Owned by: azaozz
Priority: normal Milestone: 3.6
Component: External Libraries Version: 3.5
Severity: normal Keywords: has-patch reporter-feedback
Cc:

Description

Browser: Version 6.0.2 (8536.26.17)

Target: The new media manager

Bug Description: After drag and dropping multiple images on the manager for upload, the manager becomes inaccessible.

Reason: In some cases the uploader-window fails to change display:block to display:none which makes everything on that page unclickable:

<div class="uploader-window" style="display: block; opacity: 0; "> <div class="uploader-window-content"> <h3>Drop files to upload</h3> </div> </div>

Since this is an external jQuery plugin used in Core and related to html5 structure, attached is the fix in the minified versions, as well as a standalone dev new version and the related code itself.

Attachments (4)

plupload.html5.dev.js​ (40.7 KB) - added by mario-siteground 6 months ago.
dev version created
plupload.html5.js​ (16.5 KB) - added by mario-siteground 6 months ago.
min patched
plupload.safari.patch​ (76.0 KB) - added by mario-siteground 6 months ago.
standalone bug
22974.diff​ (960 bytes) - added by nacin 5 months ago.

Download all attachments as: .zip

Change History (15)

mario-siteground — 6 months ago

dev version created

mario-siteground — 6 months ago

min patched

mario-siteground — 6 months ago

standalone bug

comment:1 mario-siteground — 6 months ago

  • Keywords has-patch added

comment:2 SergeyBiryukov — 6 months ago

  • Component changed from Media to External Libraries
  • Version changed from trunk to 3.5

Looking at plupload.safari.patch​, this looks like something that should be fixed upstream.

comment:4 nacin — 6 months ago

  • Milestone changed from Awaiting Review to 3.5.1

nacin — 5 months ago

comment:5 nacin — 5 months ago

I created a patch based on ​https://github.com/moxiecode/plupload/tree/1.x. Can you explain your changes?

comment:6 follow-up: nacin — 5 months ago

And, is this applicable to Safari for Windows only?

comment:7 nacin — 5 months ago

  • Owner set to azaozz
  • Status changed from new to assigned

comment:8 in reply to: ↑ 6 MattyRob — 5 months ago

Replying to nacin:

And, is this applicable to Safari for Windows only?

I haven't seen this issue with Safari on OSX but what makes this strange is version 6.0.2 is the current release on OSX but it seems that version 5.1.7 is the current release of Safari on Windows (​http://en.wikipedia.org/wiki/Safari_version_history). Maybe we need some reporter feedback.

comment:9 SergeyBiryukov — 5 months ago

  • Keywords reporter-feedback added

comment:10 azaozz — 5 months ago

Seems to be happening only on Safari/Windows, confirmed in 5.1.5. Can't reproduce in Safari/Mac 6.0.2.

Generally Plupload has always had some ​problems in Safari/Windows. The good news is that Plupload 2 is ​coming out soon-ish and will probably be in 3.6.

Not sure if we should patch plupload.html5.js. 22974.diff doesn't make any difference in Safari/Mac (obvious, as it runs only on Windows). In Safari/Windows 5.1.5 the patch prevents drag-drop completely (nothing happens after dropping files), without the patch drag-drop doesn't work (the first image is displayed in the browser).

Think best is to leave this for 3.6 when we will update to Plupload 2.

comment:11 azaozz — 5 months ago

  • Milestone changed from 3.5.1 to 3.6
Note: See TracTickets for help on using tickets.