Opened 5 months ago

Last modified 3 days ago

#23032 new defect (bug)

Call get_page_hierarchy without passing by reference in wp-includes/rewrite.php page_uri_index

Reported by: Askapache Owned by:
Priority: normal Milestone: Future Release
Component: Warnings/Notices Version: 3.0
Severity: minor Keywords: has-patch
Cc:

Description

PHP Strict Standards: Only variables should be passed by reference in wp-includes/rewrite.php on line 825

Due to &$pages in the function declaration.

function get_page_hierarchy( &$pages, $page_id = 0 )

Instead of calling get_page_hierarchy with the full $wpdb->get_results as the arg, save the get_results to a variable and pass that to get_page_hierarchy.

$pages = $wpdb->get_results(...)
$posts = get_page_hierarchy( $pages );

Attachments (1)

rewrite.php.patch (673 bytes) - added by Askapache 5 months ago.
Patch to call function with variable instead of referenced

Download all attachments as: .zip

Change History (3)

Patch to call function with variable instead of referenced

  • Component changed from General to Warnings/Notices
  • Milestone changed from Awaiting Review to 3.6
  • Version changed from trunk to 3.0

comment:2   ryan3 days ago

  • Milestone changed from 3.6 to Future Release
Note: See TracTickets for help on using tickets.