#23058 closed defect (bug) (fixed)
Corrected inline docs for cache.php
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.6 |
| Component: | Inline Docs | Version: | 2.5 |
| Severity: | normal | Keywords: | has-patch commit needs-codex |
| Cc: |
Description
See [6543].
There are some copy&paste issues.
Attachments (2)
Change History (10)
comment:2
SergeyBiryukov — 5 months ago
For the build in WP_Object_Cache, yes. But other implementations should be able to return false too. For example memcache::set.
comment:4
in reply to:
↑ 3
;
follow-up:
↓ 5
SergeyBiryukov — 5 months ago
Replying to ocean90:
But other implementations should be able to return false too. For example memcache::set.
Then wp_cache_flush() comment should probably also say "False on failure, true on success".
Replying to SergeyBiryukov:
Then wp_cache_flush() comment should probably also say "False on failure, true on success".
Done in 23058.2.patch.
comment:6
SergeyBiryukov — 5 months ago
- Keywords commit added
comment:7
SergeyBiryukov — 4 months ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 23328:
comment:8
DrewAPicture — 45 hours ago
- Keywords needs-codex added
See [23328] for fixes to inline docs in:
- wp_cache_add()
- wp_cache_flush()
- wp_cache_replace()
- wp_cache_set()
Note: See
TracTickets for help on using
tickets.

I guess the comment for wp_cache_set() should be "Always returns true", like the one for WP_Object_Cache::set():
http://core.trac.wordpress.org/browser/tags/3.5/wp-includes/cache.php#L560
Same as for wp_cache_flush() and WP_Object_Cache::flush():
http://core.trac.wordpress.org/browser/tags/3.5/wp-includes/cache.php#L88