WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#2314 closed defect (bug) (fixed)

Supposed wp_filter typo in wp-settings.php

Reported by: asher Owned by: anonymous
Priority: lowest Milestone:
Component: General Version: 2.0
Severity: trivial Keywords: bg|has-patch bg|commit
Cc:

Description

I'm quite new in the WordPress code so I'm not sure of what I saw but looking for wp_filter first declaration I found this in wp-settings.php :

[...]

22 unset( $wp_filter, $cache_userdata, $cache_lastcommentmodified, $cache_lastpostdate, $cache_settings, $category_cache, $cache_categories );

[...]

116 $wp_filters = array();

[...]

After a quick grep, I saw that this is the only reference to a wp_filters variable so I think it's a typo and the line 116 should be :
116 $wp_filter = array();

##START_OF_SVN_DIFF
Index: wp-settings.php
===================================================================
--- wp-settings.php (révision 3465)
+++ wp-settings.php (copie de travail)
@@ -113,7 +113,7 @@

wp_cache_init();


-$wp_filters = array();
+$wp_filter = array();

require (ABSPATH . WPINC . '/functions.php');
require (ABSPATH . WPINC . '/default-filters.php');

@@ -228,4 +228,4 @@

Everything is loaded and initialized.
do_action('init');


-?>
\ No newline at end of file
+?>
##END_OF_SVN_DIFF

Attachments (1)

wp_filter_supposed_typo.diff (478 bytes) - added by asher 7 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 asher7 years ago

The code I wrote is completely broken because of 'wiki-style' indentation so the problem is in wp-settings.php at line 116 in my svn updated version as of Fri Jan 20 11:04:35 2006.

comment:2 davidhouse7 years ago

  • Keywords bg|has-patch bg|commit added
  • Priority changed from normal to lowest
  • Severity changed from normal to trivial

Valid: $wp_filter is used everywhere else. Doesn't do any damage though.

comment:3 ryan7 years ago

  • Milestone set to 2.0.1

comment:4 ryan7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3466]) Remove unneeded (and broken) line. Props asher. fixes #2314

comment:5 anonymous7 years ago

  • Milestone 2.0.1 deleted

Milestone 2.0.1 deleted

Note: See TracTickets for help on using tickets.