[E_STRICT] mo.php import_from_reader

[zenation]

I'm getting a STRICT error for /wp-includes/pomo/mo.php saying that only variables should be passed by reference. So my suggestion is to replace line 210 (function: import_from_reader)

 $this->set_headers($this->make_headers($translation));

with these two lines

 $translationHeaders = $this->make_headers( $translation );
 $this->set_headers( $translationHeaders );

I'm looking @version $Id: mo.php 718 2012-10-31 00:32:02Z nbachiyski $

Fixed in [19072], reintroduced in [22349].

Go ahead and commit it, it's on my list to make sure the WordPress version of pomo is the canonical one.

Actually, nikolay, I'm wondering why $headers is by reference. I think we could remove it, given that we're not doing anything to $headers (and likely never would want to).

@nacin, we have a ton of references still from the old PHP4 days when objects were copied if not passed by reference. We probably don't need most of them.

we did a lot of that here [21839] and then broke i18n as per Sergey

Replying to wonderboymusic:

we did a lot of that here [21839] and then broke i18n as per Sergey

Did you really mean [21839]?

argh, that was meant to be #21839 - commits were [21792] and [21793]

Removing the reference (23232.2.patch​) actually works too.

This isn't a PHP4-style reference. It's taking an array of headers by reference, but then not changing said array, making the reference fairly useless. I'm fine with removing it. Would be good to see if blaming this gleans any light.

Introduced in [10584] along with the pomo library itself.

In 23357:

Avoid 'Only variables should be passed by reference' warning. fixes #23232.