WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#2341 closed defect (bug) (fixed)

Unable to remove user contact info

Reported by: CounterDax Owned by: davidhouse
Priority: low Milestone:
Component: Administration Version: 2.0
Severity: minor Keywords: user profile contace bg|has-patch bg|dev-feedback
Cc:

Description

When entered contact information (Jabber, AOL IM, etc), you are unable to remove the data afterwards.

Attachments (2)

2341.diff​ (548 bytes) - added by davidhouse 7 years ago.
2341-2.diff​ (557 bytes) - added by davidhouse 7 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 davidhouse — 7 years ago

  • Owner changed from anonymous to davidhouse
  • Status changed from new to assigned

comment:2 davidhouse — 7 years ago

The problem is these lines in update_usermeta():

if ( '' == $meta_value )
		return false;

What the hell is that?

davidhouse — 7 years ago

comment:3 davidhouse — 7 years ago

  • Keywords contace bg|has-patch bg|dev-feedback added; contact remove removed

Anyway, here's a patch to remove those lines. Anyone any info on why this is a bad idea?

comment:4 ryan — 7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [3494]) Allow empty usermeta fields. Props David House. fixes #2341

comment:5 matt — 7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Not allowing blank data value is actually the intended behaviour.

A better patch should just delete the row if the value is blank.

davidhouse — 7 years ago

comment:6 davidhouse — 7 years ago

As requested.

comment:7 ryan — 7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [3495]) Delete usermeta field if set to empty string. Props David House. fixes #2341

comment:8 anonymous — 7 years ago

  • Milestone 2.0.1 deleted

Milestone 2.0.1 deleted

Note: See TracTickets for help on using tickets.