get_terms() assumes its taxonomies argument is a numeric array with a 0 key

[nbachiyski]

In a few places in get_terms() we are using $taxonomies[0] after we've established that we have more than one taxonomy. The array isn't always 0-based, though.

For example, get_taxonomies() returns arrays with the taxonomy name as a key, which breaks this pattern.

In the attached patch, the taxonomies are run through array_values(), which gives us a 0-based array of the taxonomies.

Test in ​[UT1219].

Fixing ticket title to clearer terminology. Probably worth updating the patch too.

I still think 0-based is the better term.

The array, which is a result of $a = array( 1, 2, 3); unset( $a[0] ); is still numeric, but its zeroth element is missing.

Replying to nbachiyski:

I still think 0-based is the better term.

The array, which is a result of $a = array( 1, 2, 3); unset( $a[0] ); is still numeric, but its zeroth element is missing.

True!