Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#23521 closed defect (bug) (wontfix)

Twenty Thirteen: Make correct click-event for touch-devices while toggling menu in narrow viewport

Reported by: wibron Owned by:
Priority: normal Milestone:
Component: Bundled Theme Version: trunk
Severity: normal Keywords: has-patch
Cc:

Description

The touchstart-event should be used instead of the click-event because it removes the delay on touchdevices.

Attachments (1)

click-event.patch​ (555 bytes) - added by wibron 3 months ago.

Download all attachments as: .zip

Change History (8)

wibron — 3 months ago

comment:1   SergeyBiryukov — 3 months ago

  • Component changed from Themes to Bundled Theme
  • Summary changed from Twenty thirteen: Make correct click-event for touch-devices while toggling menu in narrow viewport to Twenty Thirteen: Make correct click-event for touch-devices while toggling menu in narrow viewport

comment:2   lancewillett — 3 months ago

  • Keywords dev-feedback added
  • Milestone changed from Awaiting Review to 3.6
  • Type changed from enhancement to defect (bug)

comment:3   obenland — 3 months ago

  • Keywords reporter-feedback added; dev-feedback removed

The delay on touchdevices has the purpose of determining whether it's a double-click or not. Currently the experience of opening the menu is coherent with that of opening the search bar.

What makes 'touchstart' more correct than 'click'?

comment:4   lancewillett — 3 months ago

I vote to "wontfix" this one, it's working well in testing and we're using the same event handler as the menu in Twenty Twelve.

comment:5   obenland — 3 months ago

  • Keywords reporter-feedback removed
  • Milestone 3.6 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

I agree, let's keep as is.

comment:6   obenland — 3 months ago

  • Milestone set to 3.6

comment:7   SergeyBiryukov — 3 months ago

  • Milestone 3.6 deleted
Note: See TracTickets for help on using tickets.