Opened 3 months ago
Closed 3 months ago
#23522 closed enhancement (wontfix)
Twenty Thirteen: Highlight post author comments
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | low | Milestone: | |
| Component: | Bundled Theme | Version: | trunk |
| Severity: | normal | Keywords: | has-patch |
| Cc: |
Description
Previous bundled themes highlight comments by the current post author. Twenty Thirteen should do the same.
Attachments (2)
Change History (11)
johnbillion — 3 months ago
comment:1
johnbillion — 3 months ago
comment:2
lancewillett — 3 months ago
- Milestone changed from Awaiting Review to 3.6
Do you mean "Highlight post author comments *better*"? They are already styled with a star in front of the username: http://cl.ly/image/1B0h3L161b1k
comment:3
johnbillion — 3 months ago
Okay yeah I do mean that. I hadn't even spotted the star. I personally like the "Post author" message that Twenty Twelve adds.
comment:4
lancewillett — 3 months ago
- Keywords has-patch ui-feedback needs-testing added
- Type changed from feature request to enhancement
Added a patch with added text label; patch includes styles from @joen.
comment:5
SergeyBiryukov — 3 months ago
Would it make sense to use get_post() instead of the global (for consistency with [21735])?
I am not a huge fan of 23522.patch because it makes it more difficult to adopt the standard wp_list_comments() comment callback.
Yes, get_post() makes more sense, but since $comment is actually passed to the callback, I'd avoid using any global state if possible.
comment:7
lancewillett — 3 months ago
- Keywords ui-feedback needs-testing removed
- Priority changed from normal to low
I agree with Nacin -- we should favor core HTML5 output over custom theme-specific output.
If we can get #20088 into 3.6 we can close this ticket "wontfix".
comment:8
lancewillett — 3 months ago
- Milestone 3.6 deleted
I looped back with Joen, and he was clear that just the star was the intention of the design to indicate the post author.
comment:9
lancewillett — 3 months ago
- Resolution set to wontfix
- Status changed from new to closed

Screenshot of Twenty Twelve