WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 4 months ago

#23580 closed defect (bug) (fixed)

Twenty Thirteen: better CSS selector for widget titles

Reported by: aaroncampbell Owned by: lancewillett
Priority: normal Milestone: 3.6
Component: Bundled Theme Version:
Severity: normal Keywords: has-patch commit
Cc:

Description

Some widgets wrap the title and content in an extra wrapper to allow additional styling. Since the style used for widget headers is .widget > h3 that breaks. Widget titles already have a widget-title class. Can we use that?

Attachments (2)

23580.diff​ (420 bytes) - added by saracannon 4 months ago.
widget-title class
23580.2.diff​ (541 bytes) - added by lancewillett 4 months ago.

Download all attachments as: .zip

Change History (6)

saracannon — 4 months ago

widget-title class

comment:1 aaroncampbell — 4 months ago

  • Keywords has-patch commit added; needs-patch removed

Thanks Sara. 23580.diff​ works for me.

lancewillett — 4 months ago

comment:2 lancewillett — 4 months ago

Probably doesn't even need the h3 in the selector. .widget .widget-title should work, and is simpler.

New patch also adjusts another case where it can use the class instead.

comment:3 lancewillett — 4 months ago

  • Summary changed from Twenty Thirteen: Better CSS for Widget Title to Twenty Thirteen: better CSS selector for widget titles

comment:4 lancewillett — 4 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23490:

Twenty Thirteen: better selector for widget titles. Fixes #23580.

Note: See TracTickets for help on using tickets.